[Samba] vfs_fruit & resource forks on macOS

[Perttu Aaltonen]

> On 23 Oct 2019, at 18.54, Ralph Boehme <slow at samba.org> wrote:
> 
> On 10/23/19 4:31 PM, Perttu Aaltonen via samba wrote:
>> From version 4.10.6 onwards folder icons are not working anymore on macOS. I can see the "._Icon?” file written on disk but seems like Samba isn’t reading it back and presenting it to the client. Is there a change or new setting that is needed on more recent versions, or have I hit a bug? I noticed 4.10.6 had some work done regarding AppleDouble and resource forks.
>> 
>> In the client log I’m seeing this, not sure if it’s related:
>> 
>> [2019/10/21 21:20:32.854630,  1] ../../source3/modules/vfs_fruit.c:979(ad_unpack)
>>  Limiting ADEID_RFORK: off: 82, len: 65454
> 
> this log message indicates that the resource fork length given in the
> AppleDouble header of the file is bigger the actual on disk file.
> 
> Iirc this change has been there since ages. It was added with bugfix
> 11125 for 4.2.something.
> 
> Can you share a copy of an Icon file so I can check?
> 
> -slow
> 

It’s just a standard folder icon from macOS user home folder. For example the Desktop folder icon copy pasted to a folder on the Samba share. Size is 1321915.

On 4.10.5 it worked but with the same configuration after updating to 4.10.6 it doesn’t work. I first noticed it when installing packages for 4.10.9 so I then compiled all the versions between 4.10.4 and 4.10.9 and it breaks for me on 4.10.6. I’m using ZFS on Linux as the back end file system.

If I ‘make uninstall’ 4.10.6 and install 4.10.5 again I can instantly see the icons again and no error in log.

-Perttu