[Samba] get_share_mode_lock:, get_static_share_mode_data failed: NT_STATUS_NO_MEMORY with Samba 4.11.2

[L.P.H. van Belle]

Hai, 

I'm wondering, why this is not in 4.11 ? 
The current error messages, makes people look in the wrong direction. 

Do you know if its prepaired it for next release? Else i'll patch it into my builds.

Rowland, tell me, how did you find the change through git, thats still a part i need to improve. :-/
I looked in bugzilla, but was not able to find it. 


Thanks, i noticed this one also.

Greetz, 

Louis




> -----Oorspronkelijk bericht-----
> Van: samba [mailto:samba-bounces at lists.samba.org] Namens 
> Rowland penny via samba
> Verzonden: vrijdag 29 november 2019 10:24
> Aan: samba at lists.samba.org
> Onderwerp: Re: [Samba] get_share_mode_lock:, 
> get_static_share_mode_data failed: NT_STATUS_NO_MEMORY with 
> Samba 4.11.2
> 
> On 29/11/2019 08:04, Christian Naumer via samba wrote:
> > Hello all,
> > after the upgarde from Samba 4.10.7 to 4.11.2 we get lots 
> of these in
> > our logfiles:
> >
> >
> > 2019-11-28T20:40:44+01:00 lx-sv-09 smbd_audit: [2019/11/28
> > 20:40:44.886615,  1]
> > ../../source3/locking/share_mode_lock.c:597(get_share_mode_lock)
> > 2019-11-28T20:40:44+01:00 lx-sv-09 smbd_audit:  get_share_mode_lock:
> > get_static_share_mode_data failed: NT_STATUS_NO_MEMORY
> >
> > There are no symptoms accept those errors in the logs.
> 
> There wouldn't be, it isn't an error ;-)
> 
> If you look at '/source3/locking/share_mode_lock.c' 
> 'get_share_mode_lock'
> 
> The relevant part is this:
> 
>          status = get_static_share_mode_data(
>              static_share_mode_record,
>              id,
>              servicepath,
>              smb_fname,
>              old_write_time);
>          if (!NT_STATUS_IS_OK(status)) {
>              DBG_WARNING("get_static_share_mode_data failed: %s\n",
>                      nt_errstr(status));
>              goto fail;
>          }
> 
> It calls 'get_static_share_mode_data' and the relevant part 
> of that is this:
> 
>      if (value.dptr == NULL) {
>          d = fresh_share_mode_lock(
>              lock_db, servicepath, smb_fname, old_write_time);
>          if (d == NULL) {
>              return NT_STATUS_NO_MEMORY;
>          }
> 
> Which I hope you can see, is saying that it cannot find the share 
> record, this isn't an actual error.
> 
> It has also been fixed in Samba git, see here:
> 
> https://git.samba.org/?p=samba.git;a=commitdiff;h=79e3b1c71f59
> 591c54e87299984e50d2ffb00b6b
> 
> So, you can just ignore them ;-)
> 
> Rowland
> 
> 
> 
> -- 
> To unsubscribe from this list go to the following URL and read the
> instructions:  https://lists.samba.org/mailman/options/samba
> 
>