[Samba] samba-tool max-pwd-age error

[Tim Beale]

Apologies, this bug fell through the cracks and the fix never got
backported to 4.10. I've uploaded the backport to the bug now, it just
needs a review signoff.

To recap, it was introduced as a side-effect of switching to Python 3.
The old code never worked as intended on Python 2, but on Python 3 it
now throws an exception.

Rowland, the code in master is correct, as far as I can tell.
Unfortunately the code is complicated by the fact the tool is trying to
support changing 9 different settings independently of each other. The
parameters default to None so that the tool can tell whether or not the
user specified a given parameter. E.g. if you wanted to change the
min-pwd-age to 14 days, then later wanted to change the
account-lockout-duration to 60 minutes, you don't want running the 2nd
command to reset the min-pwd-age back to the default.

On 6/05/19 8:59 PM, Rowland Penny via samba wrote:
> On Mon, 6 May 2019 08:21:15 +0000 (UTC)
> Billy Bob via samba <samba at lists.samba.org> wrote:
>
>> See:
>>
>>
>>
>>
>> https://bugzilla.samba.org/show_bug.cgi?id=13873
>>
>>
>> and
>>
>>
>> https://lists.samba.org/archive/samba/2019-March/222141.html
>>
>>
>> These seem related, if not the same.
> They are, a bit more investigation, reveals why this has all come about.
> It appears that if you didn't supply the minimum password age on
> earlier versions, AD was searched for it, it isn't now, but the same
> code to check is still being used.
>
> Rowland
>
>
>