[Samba] Online Backup Fails - list index out of range

[Tim Beale]

On 30/08/19 4:20 AM, Roy Eastwood via samba wrote:
> INFO 2019-08-29 17:04:06,889 pid:13945 /usr/lib/python3/dist-packages/samba/join.py #1643: Setting isSynchronized and dsServiceName
> INFO 2019-08-29 17:04:07,303 pid:13945 /usr/lib/python3/dist-packages/samba/join.py #1555: Cloned domain MICROLYNX (SID
> S-1-5-21-4012640977-2272627666-3977488320)
> ERROR(<class 'IndexError'>): uncaught exception - list index out of range
>   File "/usr/lib/python3/dist-packages/samba/netcmd/__init__.py", line 185, in _run
>     return self.run(*args, **kwargs)
>   File "/usr/lib/python3/dist-packages/samba/netcmd/domain_backup.py", line 258, in run
>     new_sid = get_sid_for_restore(remote_sam)
>   File "/usr/lib/python3/dist-packages/samba/netcmd/domain_backup.py", line 81, in get_sid_for_restore
>     rid = int(res[0].get('rIDNextRID')[0])
>
> Is this another bug?

It's not really a bug. The backup process needs to allocate a new RID
and the DC you're running the backup against doesn't have a RID pool
allocated. E.g. see:

https://lists.samba.org/archive/samba/2019-February/221619.html

I have improved the error message you get in this case on master, but I
haven't backported this yet.