[Samba] selftest

[Manfred]

Inspecting the errors I think the following is not as expected:

1) in 'testprogs/blackbox/demote-saveddb.sh':
=============================
...

if [ -d $tree_dir ]; then
     testit "undump" undump
     testit "demote-q-0-0" demote "q-0-0"
     # The database was copied of q-0-1 so this will fail
     # as we can't remove our own name
     testit_expect_failure "demote-q-0-1" demote "q-0-1"
     testit "demote-q-1-0" demote "q-1-0"
     testit "demote-q-1-1" demote "q-1-1"
else
     subunit_start_test "undump"
     subunit_skip_test "undump" <<EOF
no test provision
EOF

     subunit_start_test "demote-q-0-0"
     subunit_skip_test "demote-q-0-0" <<EOF
no test provision
EOF
     subunit_start_test "demote-q-0-1"
     subunit_skip_test "demote-q-0-1" <<EOF
no test provision
EOF
/*** HERE IT LOOKS LIKE THE FOLLOWING SHOULD BE 'q-1-0' ***/ <=====
     subunit_start_test "demote-q-1-1"
     subunit_skip_test "demote-q-0-1" <<EOF
no test provision
EOF
     subunit_start_test "demote-q-1-1"
     subunit_skip_test "demote-q-1-1" <<EOF
no test provision
EOF
fi

...
===================================================


2) But then I see that I have no 'provisions' directory.
Is this expected?
If not, how can I get one?

Thanks in advance,

Manfred


On 4/1/19 10:55 PM, Andrew Bartlett wrote:
> On Mon, 2019-04-01 at 20:34 +0200, Manfred via samba wrote:
>> Thanks for the reply,
>>
>> Besides the problem with
>> source4/lib/messaging/messaging_handlers.c,
>>
>> Good to hear that selftest is actively used, then do I understand it
>> right that 'make test' should succeed?
> 
> After about four hours, yes.
> 
>> My bigger problem is that it failed with lots of errors.
>> This must be a problem with my build, then, but since this is a fresh
>> tarball I am a bit puzzled.
>>
>> I would appreciate some hint on where to start looking for any mistake.
>>
>> My environment:
>> Fedora 28
>> ./configure --enable-selftest
>> make -j16
>> make test
>>
>> All run as the ordinary user - I understand from the 2012 talk that
>> 'root' privileges should not be needed. Do I get this wrong?
> 
> Root privileges are not required.  While 'make test' is intended to
> pass generally, the reference environment is Ubuntu 14.04 (soon to be
> upgraded to 18.04 for the next release).
> 
> We would need to see the errors to diagnose further.
> 
> Andrew Bartlett
>