[Samba] vfs_full_audit and facility 'auth'...

[Timur I. Bakeyev]

On 11 May 2018 at 22:17, Jeremy Allison <jra at samba.org> wrote:

> On Fri, May 11, 2018 at 09:56:47PM +0200, Timur I. Bakeyev via samba wrote:
> > >
> > Fixing it in both ways is easy, but it would be nice to hear from the
> > developers, why did they choose such a limited set of syslog facilities.
>
> I don't know. The limited set was done a long time ago
> (2005) by Deryck (no longer a Team member) in commit
> 435295f1840aa8bd4c04f20a2348c6d701c6b7dc so I think
> we've lost the institutional memory here.
>
> How about we fix the code to do what the man page
> says ?


I'm all for it. I don't see any security implications of allowing full set
of supported syslog facilities. Just to keep in mind that the same code is
shared by vfs_audit, vfs_ext_audit and vfs_full_audit, so all of them have
to be fixed.

With regards,
Timur.