[Samba] Samba upgrade

[Michael Howard]

I'm upgrading an old samba4 instance (Samba version: 
4.3.0pre1-GIT-1e32ada) which despite it's age works fine. Running 
'samba-tool dbcheck --cross-ncs' before the upgrade results in no errors.

Building and installing using samba-4.7.3.tar.gz source (same 
./configure) and the running 'samba-tool dbcheck --cross-ncs' results in 
'Checked 3994 objects (4367 errors)' and then an endless loop of .......

# samba-tool dbcheck --cross-ncs --fix --yes
Checked 3994 objects (4440 errors)
# samba-tool dbcheck --cross-ncs
Checked 3994 objects (434 errors)
# samba-tool dbcheck --cross-ncs --fix --yes
Checked 3994 objects (456 errors)
# samba-tool dbcheck --cross-ncs
Checked 3994 objects (434 errors)
# samba-tool dbcheck --cross-ncs --fix --yes
Checked 3994 objects (456 errors)

..... and so on. Anybody know if there is a way out of this loop? Maybe 
migrating to a new DC is the way to go. Any suggestions of the best 
approach in that scenario, to avoid manual input ans lots of scripting? 
Should it just be a case of new DC, promote, demote old DC?

Cheers,

-- 
Mike Howard