[Samba] samba-4.5.1 build problem

[Andrew Bartlett]

On Wed, 2016-10-26 at 10:21 +0200, Peter Serbe via samba wrote:
> Dear Samba experts, 
> 
> I tried to install the latest Samba release the way I 
> did it always, i.e. starting with:
> 
> ./configure --prefix=/usr/local/samba \
>             --with-piddir=/usr/local/samba/var/run \
>             --with-syslog \
>             --with-quotas \
>             --with-acl-support \
>             --enable-debug \
>             --enable-cups \
>             --enable-selftest \
>             --with-ads \
>             --with-shared-modules=idmap_ad
> 
> But after a short while this stops throwing an error, 
> which is totally cryptic to me
> 
> Checking for perl
> 5.0.0                                                           : ok
> 5.24.1
> Checking for perl
> $Config{vendorprefix}:                                          :
> '/usr'
> PERL_ARCH_INSTALL_DIR:                                               
>              : '${LIBDIR}/perl5'
> PERL_LIB_INSTALL_DIR:                                                
>              : '${DATADIR}/perl5'
> Traceback (most recent call last):
>   File "./buildtools/bin/waf", line 76, in <module>
>     Scripting.prepare(t, cwd, VERSION, wafdir)
>   File "/usr/src/samba/samba-
> 4.5.1/third_party/waf/wafadmin/Scripting.py", line 145, in prepare
>     prepare_impl(t, cwd, ver, wafdir)
>   File "/usr/src/samba/samba-
> 4.5.1/third_party/waf/wafadmin/Scripting.py", line 135, in
> prepare_impl
>     main()
>   File "/usr/src/samba/samba-4.5.1/wscript", line 347, in main
>     wildcard_main(wildcard_cmd)
>   File "./buildtools/wafsamba/samba_wildcard.py", line 110, in
> wildcard_main
>     fun(ctx)
>   File "/usr/src/samba/samba-
> 4.5.1/third_party/waf/wafadmin/Scripting.py", line 241, in configure
>     conf.sub_config([''])
>   File "/usr/src/samba/samba-
> 4.5.1/third_party/waf/wafadmin/Configure.py", line 237, in sub_config
>     self.recurse(k, name='configure')
>   File "/usr/src/samba/samba-
> 4.5.1/third_party/waf/wafadmin/Utils.py", line 656, in recurse
>     f(self)
>   File "/usr/src/samba/samba-4.5.1/wscript", line 103, in configure
>     conf.SAMBA_CHECK_PERL(mandatory=True)
>   File "./buildtools/wafsamba/samba_perl.py", line 52, in
> SAMBA_CHECK_PERL
>     perl_inc.remove('.')
> ValueError: list.remove(x): x not in list
> 
> What should I do to overcome this?

I patched this at work yesterday.  I'll get you the patch when I get
back to Catalyst tomorrow.

It wasn't hard, just something like adding:

if '.' in perl_inc:

at the indicated line.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba