[Samba] [WIP][PATCH] 'fix' smbspool_krb5_wrapper, libexecdir and ctdb helper binary locations for 4.4

Miguel Medalha medalist at sapo.pt
Sun Mar 20 18:57:40 UTC 2016


>>> When building Samba 4.4.0rc and then doing an install to
>>> /usr/local/samba, a directory "libexec" is being created which then
>>> contains a "samba" directory with a single "smbspool_krb5_wrapper"
>>> file inside (/usr/local/samba/libexec/samba/
>>> smbspool_krb5_wrapper). This is not very clean, is it?
>>>
>>> Since all the files are already inside /usr/local/samba, why repeat
>>> "samba" again inside the tree? Is it possible to clean this before
>>> the final release of Samba 4.4.0?
>>>
>>> This doesn't happen with version 4.3.6. The same file is placed in
>>> "/usr/local/samba/bin/smbspool_krb5_wrapper".
>> Some additional information: if I configure the build with
>> "--libexecdir=/usr/local/samba/bin" the file goes into
>> "usr/local/samba/bin/samba/smbspool_krb5_wrapper" which also contains
>> an
>> unnecessary repetition. That additional "samba" directory seems to be
>> hard coded somewhere.
> Try this patch.

Thank you for writing the patch.

Maybe I am being picky or (most probably) ignoring some valid motive, 
but why does "smbspool_krb5_wrapper" need a "libexec" directory just for 
itself? Was there something wrong with keeping this file in 
"/usr/local/samba/bin" as it happened with samba 4.3.6? Why complicate 
the tree?




More information about the samba mailing list