[Samba] Issue with acl_xattr:ignore system acls in 4.5rc2

[Ralph Böhme]

Hi Jeremy,

On Mon, Aug 29, 2016 at 01:38:21PM -0700, Jeremy Allison wrote:
> On Sat, Aug 27, 2016 at 12:46:12PM +0200, Ralph Böhme via samba wrote:
> > 
> > ...and this one even has bug urls in all commit messages. Sorry for
> > forgetting this in the previous version.
> 
> Juuuusttt *one* leetle change, sorry :-).

:)

> I was following the changes to the talloc heirarchy in the
> code and realized that adding the following change made it
> much clearer (at least to me).
> 
> diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
> index 2163a75..870e6da 100644
> --- a/source3/modules/vfs_acl_common.c
> +++ b/source3/modules/vfs_acl_common.c
> @@ -625,7 +625,7 @@ static NTSTATUS validate_nt_acl_blob(TALLOC_CTX *mem_ctx,
>                                      vfs_handle_struct *handle,
>                                      files_struct *fsp,
>                                      const struct smb_filename *smb_fname,
> -                                    DATA_BLOB *blob,
> +                                    const DATA_BLOB *blob,
>                                      struct security_descriptor **ppsd,
>                                      bool *psd_is_from_fs)
>  {
> 
> Making the blob pointer parameter to validate_nt_acl_blob() const helps
> be realize it's an 'in' parameter the function should be messing with
> (and extra const is always good, right ?).

makes perfect sense.

> Also, as you've re-written most of this can I add your name as a
> 
> diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
> index 2163a75..fa65fd1 100644
> --- a/source3/modules/vfs_acl_common.c
> +++ b/source3/modules/vfs_acl_common.c
> @@ -4,6 +4,7 @@
>   *
>   * Copyright (C) Volker Lendecke, 2008
>   * Copyright (C) Jeremy Allison, 2009
> + * Copyright (C) Ralph Böhme, 2016
>   *
> 
> to the top as well ? If you're good with these changes squashed
> in, 'Reviewed-by: Jeremy Allison <jra at samba.org>'

ack.

> Let me know and I'll push.

yes please. :)

Thanks!

Cheerio!
-slow