[Samba] Samba 4.4.2 AD DC demote fails

Miguel Medalha medalist at sapo.pt
Sat Apr 30 21:25:32 UTC 2016


The attachment "https://bugzilla.samba.org/attachment.cgi?id=11953" that 
you submitted to "https://bugzilla.samba.org/show_bug.cgi?id=11818" 
contains the following:

-        remove_dc.remove_sysvol_references(remote_samdb, dc_name)
+        remove_dc.remove_sysvol_references(remote_samdb, logger, dc_name)


Yet, on a post to "https://lists.samba.org/archive/samba/2016-March/198662.html" you wrote:


HI, it would seem you have found a bug, line 943 in 'domain.py' sends this:

          remove_dc.remove_sysvol_references(remote_samdb, dc_name)

to 'remove_dc.py' , which expects to receive this:

def remove_sysvol_references(samdb, logger, dc_name):

Looking at the code in 'remove_dc.py' (line 37), it looks like the 
correct patch would be:

-        remove_dc.remove_sysvol_references(remote_samdb, dc_name)
+        remove_dc.remove_sysvol_references(samdb, logger, dc_name)


Is this correct?




More information about the samba mailing list