[Samba] Samba 4.4.2 AD DC demote fails

[Andrew Bartlett]

On Sat, 2016-04-30 at 16:35 +0100, Miguel Medalha wrote:
> 
> >  In any case, I found and fixed the issue you hit last week, the
> > patch is at https://bugzilla.samba.org/show_bug.cgi?id=11882 The
> > syntax error should then go away (bug I have a patch for that as
> > well, it is on samba-technical if you are curious). 
> I found this on a post by Rowland penny (
> https://lists.samba.org/archive/samba/2016-March/198662.html):
> 
> HI, it would seem you have found a bug, line 943 in 'domain.py' sends
> this:
> 
> 	remove_dc.remove_sysvol_references(remote_samdb, dc_name)
> 
> to 'remove_dc.py' , which expects to receive this:
> 
> 	def remove_sysvol_references(samdb, logger, dc_name):
> 
> Definitely a bug, logger is set earlier in the 'cmd_domain_demote'
> class.
> 
> 
> Would this still apply after the patches you did? (By the way, I
> already found the one on samba.technical)

Yes, that still applies.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba