[Samba] [PATCH] Re: Samba 4.1.17 classic update w/LDAP - parsing error

[Andrew Bartlett]

On Thu, 2015-09-24 at 09:12 +0200, Michael Wood wrote:
> Hi
> On 23 Sep 2015 9:47 PM, "Andrew Bartlett" <abartlet at samba.org> wrote:
> >
> > On Thu, 2015-09-24 at 06:59 +1200, Andrew Bartlett wrote:
> > >
> > > That looks like a bug.  My guess is that, as Roland suggested,
> the
> > > group name isn't just normal characters.  We do support other
> chars
> > > in
> > > group names, but the bug here was not to escape the values.  You
> > > could
> > > expect a particular problem with any of these in particular: =,()
> >
> > Can you confirm this patch (against master, but should apply back
> to
> > 4.1) works for you?
> >
> > If so, can I get a second team member to review/push?
> Does that still result in them being in CN=Users? Or is that not
> important?

Indeed, that is what I get for writing patches at 7 in the morning :-)

Try the attached.  We really, really need some good expected-value
testing of the upgrade system.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-classicupgrade-Avoid-needing-to-quote-CN-values-in-a.patch
Type: text/x-patch
Size: 1372 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba/attachments/20150924/f43ac7bf/0001-classicupgrade-Avoid-needing-to-quote-CN-values-in-a.bin>