[Samba] [PATCH] AD DC auto added vfs modules not present if "vfs objects" is explicitly configured

[David Disseldorp]

Hi Klaus,

Thanks for your input...

On Thu, 01 May 2014 00:00:16 +0200, Klaus Hartnegg wrote:

> On 30.04.2014 11:35, David Disseldorp wrote:
> > In fixing this, I'm evaluating the following options:
> > 1. Print a loud warning in the log (and possibly fail to start) when
> >     an AD DC configured server includes an explicit "vfs objects"
> >     definition that does not include the modules that it requires
> >     (dfs_samba4, acl_xattr).
> > 2. Append the required vfs modules to any explicit "vfs objects"
> >     definition, filtering out duplicates.
> 
> (1) would replace the problem with another one.
> (2) would fix it.

VFS modules often have strict ordering requirements, and may not play
well with others. So I don't think (2) is a plausible fix.

> How about (3): the provision script should add that line to smb.conf, 
> samba should warn if the required vfs objects are not in the list any 
> more, and then it should behave as if they were.

This sounds reasonable, but I'm not at all familiar with the existing
provision script code. Is it currently responsible for writing out a
fresh AD DC smb.conf? Are there situations where it modifies an existing
config in-place? If the latter is true, then we'd still be susceptible
to the issues faced with (2).

I've attached a patch that adds the warning proposed with (1)/(3).
Feedback / testing would be much appreciated.

Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-loadparm-check-for-AD-DC-required-VFS-modules.patch
Type: text/x-patch
Size: 2779 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba/attachments/20140502/a8e9963b/attachment.bin>