[Samba] Inconsistent performance (4.1.6)

[Jeremy Allison]

On Fri, Apr 11, 2014 at 01:37:03PM +0200, Volker Lendecke wrote:
> On Thu, Apr 10, 2014 at 10:12:43AM -0700, Jeremy Allison wrote:
> > The only safe way to use aio is to use it via the
> > samba-coded pthread module, which doesn't suffer
> > from these problems.
> 
> What version are we looking at here? From the subject of the
> mail I guessed that we are talking about 4.1.6. In 4.1.6, I
> see a line
> 
>         ret = asys_pread(state->asys_ctx, fsp->fh->fd, data, n, offset, req);
> 
> in vfs_default.c, so my gut feeling would be that this
> version does not need the explicit aio_pthread module for
> async read/write. Please apologize my ignorance if we are
> talking about the async file creation, but I could not read
> that from this mail thread so far.

You know, you're completely right ! I'd forgotten
that change went in, meaning we do pthread async
read/write IO if we're configured with pthreads
even without the vfs_pthread module.

I must be getting old :-). Thanks for correcting
my misconceptions on the list.

Now it's *ME* who is coming out with voodoo
bullshit that'll be repeated erroneously as
gospel in the future :-).

Sorry about that !

Jeremy.