[Samba] Conversion error: Illegal multibyte sequence

[Volker Lendecke]

On Tue, Sep 10, 2013 at 09:48:57AM -0700, Jeremy Allison wrote:
> It's an old, old check back from when SJIS and EUC were
> common multi-byte systems.
> 
> SJIS especially has the property that the second byte
> can contain a value <127 as part of the 2-byte char
> set. So if CH_UNIX is set to a char set with such a
> property we can't walk it as bytes, but must see if
> a pair of values [0] (> 0x80) [1] (any value) can be
> converted into a valid multi-byte char, in which case
> we ignore it (otherwise we might look at the second
> byte value of ':' or something and consider it invalid).
> 
> I thought about removing this and re-writing it, but
> it made my brain hurt (and might break some very old
> systems :-). So moving to next_codepoint() which checks
> the next char len without causing the conversion error
> messages seemed the simplest fix :-).

Thanks! +1 from me.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

*****************************************************************
visit us on it-sa:IT security exhibitions in Nürnberg, Germany
October 8th - 10th 2013, hall 12, booth 333
free tickets available via code 270691 on: www.it-sa.de/gutschein
******************************************************************