[Samba] [PATCH] Do not close winbind socket during use

Andrew Bartlett abartlet at samba.org
Wed Jun 26 19:42:50 MDT 2013

On Wed, 2013-06-26 at 20:39 +1000, Andrew Bartlett wrote:
> On Mon, 2013-06-24 at 15:26 +0000, Philippe.Simonet at swisscom.com wrote:
> > Hi Andrew, and by putting more num-callers : 
> > 
> > valgrind --num-callers=50 samba -i -M single
> Thanks for getting me that.  I've managed to reproduce it here, but not
> under valgrind, and only when I hack the code to force a timeout.  At
> least this should help me figure out why we process the winbind socket
> close, which is the crux of this issue.

I think I've found the cause of the issue you are hitting.  There is
still another issue with the nested event loop in the krb5 libs, but
these two patches should help significantly.

As you have had more luck than I in reproducing this in a unaltered
setting, please let me know if this helps.

Patches are for git master, but may apply to 4.0 as well.

Kai, Metze:

In reading the code, I cannot see why the DNS server would not suffer
the same issue, if the DNS clients closed it's socket.  Should we find a
more generic way to do this in service_stream, or should just duplicate
this?  I don't think other servers hit the same issue as they are
currently 'blocking' in terms of the socket handler. 


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-service_stream-Log-if-the-connection-termination-is-.patch
Type: text/x-patch
Size: 936 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba/attachments/20130627/a28a1118/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-winbindd-Do-not-terminate-a-connection-that-is-st.patch
Type: text/x-patch
Size: 3128 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba/attachments/20130627/a28a1118/attachment-0001.bin>

More information about the samba mailing list