[Samba] Samba4 - Wins error running samba-tool classicupgrade

[Andrew Bartlett]

On Fri, 2012-11-16 at 15:47 -0300, Federico Alberto Sayd wrote:
> On 16/11/12 13:00, Federico Alberto Sayd wrote:
> > Hello:
> >
> > First, sorry for my English.
> >
> > I'm testing samba4 rc5. I have compiled and installed samba4 and now 
> > I'm trying to simulate an upgrade from my samba3 site to my samba4 
> > test installation. I have setup a isolated network and I have 
> > replicated server and clients, copied my samba3 ldap contents and tdb 
> > files.
> >
> > But, when I run samba-tool classicupgrade following to the docs, 
> > samba-tool complaints about wins error.
> >
> > Below is the error. When the error appeared, I manually deleted the 
> > name entries in the wins.dat file, but the error continues with other 
> > machine names.
> >
> > Can I delete the wins.dat (entirely or its content) without consecuences?
> >
> > I have re-run the samba-tool classicupgrade after every error. Need I 
> > to wipe the internal samba4 database before re-run samba-tool 
> > classicupgrade? If, "yes", how?
> >
> >
> > Importing WINS database
> > ERROR (ldb): uncaught exception - Entry name=REP-01-FUN01, type=0x20 
> > already exists
> >     File 
> > "/usr/local/samba/python2.7/site-packages/samba/netcmd/__init__.py", 
> > line 175 in _run
> >         return self.run(*args, **kwargs)
> >     File 
> > "/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/domain.py", 
> > line 1318, in run
> >         useeadb=eadb, dns_backend=dns_backend, use_ntvfs=use_ntvfs)
> >     File 
> > "/usr/local/samba/lib/python2.7/site-packages/samba/upgrade.py", line 
> > 848, in upgrade_from_samba3
> >         import_wins(Ldb(result.paths.winsdb), samba3_winsdb)
> >     File 
> > "/usr/local/samba/lib/python2.7/site-packages/samba/upgrade.py", line 
> > 364, in import_wins
> >         "address": ips})
> >
> >
> > Regards
> >
> > Federico
> I have read the samba 3 docs, and this page[1] says that there is not 
> need to preserve winds.dat because this file is regenerated when Samba 
> is restarted. I deleted the file and the migration finished ok.
> 
> it is ok to delete this file?

It is and it isn't.  The client will eventually re-register itself with
WINS, but it won't be immediate. 

The correct fix would be to work out what nmbd does with a duplicate
entry (does it just take the first or last entry?) and then do the same
in the upgrade code.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org