[Samba] smbclient 3.5.6 potential bug: 100-character filenames not extracted properly from tar

[Bjoren Davis]

Hello Samba folks,
I have come across a problem with smbclient 3.5.6 when I use the tar 'x' feature.
Pathnames that work out to be 100 characters long are extracted incorrectly:
bash-3.2$ tar tvf ugh.tar
-rw-r--r-- bdavis/Domain Users 137 2012-12-07 13:36:40 a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD/a49characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABC
-rw-r--r-- bdavis/Domain Users 138 2012-12-07 13:37:11 a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD/a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD
bash-3.2$ smbclient --version
Version 3.5.6
bash-3.2$ smbclient //XXXXXXX/Temp30Day -U XXXXXX/bdavis
Enter XXXXXX/bdavis's password:
Domain=[XXXXXXX] OS=[Windows Server 2003 3790 Service Pack 2] Server=[Windows Server 2003 5.2]
smb: \> cd bdavis
smb: \bdavis\> tar x ugh.tar
restore tar file \bdavis\a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD\a49characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABC0000644 of size 137 bytes
restore tar file \bdavis\a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD\a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD of size 138 bytes
tar: restored 2 files and directories
smb: \bdavis\> cd a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD\
smb: \bdavis\a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD\> dir
  .                                   D        0  Fri Dec  7 13:44:34 2012
  ..                                  D        0  Fri Dec  7 13:44:34 2012
  a49characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABC0000644             137  Fri Dec  7 13:36:40 2012
  a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD             138  Fri Dec  7 13:37:11 2012

                35000 blocks of size 4194304. 10651 blocks available
smb: \bdavis\a50characterpathnameABCDEFGHIJKLMNOPQRSTUVWXYZABCD\> exit

As you can see, the file with the 100 character pathname is extracted with its octal permissions concatenated to the name.
I'm attaching the tar file that I used.
I don't know if this problem is fixed in a newer release of smbclient.
Please let me know if there's more information you need.
Thanks.
--Bjoren Davis