[Samba] Another problem with samba4 classicupgrade

[Andrew Bartlett]

On Thu, 2012-08-23 at 11:18 +0200, Hervé Hénoch wrote:
> For information :
> 
> I've commented out the line 831 in the file 
> /usr/local/samba/lib/python2.7/site-packages/samba/upgrade.py :
> 
> #shells[username] = get_posix_attr_from_ldap_backend(logger, ldb_object, 
> base_dn, username, "loginShell")
> 
> And the migration was successfull. An explanation would be welcome.

Clearly we need to have some more try/except clauses here.

Would you like to try an write a patch?  

eg for each of those get_posix_attr_from_ldap_backend, change that line
to:

try:
  shells[username] = get_posix_attr_from_ldap_backend(logger,
ldb_object, 
base_dn, username, "loginShell")
except KeyError:
  pass

If you can send me back a tested patch, I'll get it into master.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org