[Samba] Samba 3.6.4 segfaults on guest authentication

[Volker Lendecke]

On Thu, Apr 12, 2012 at 11:41:14AM +0200, Christian Manal wrote:
> On 12.04.2012 11:38, Volker Lendecke wrote:
> > On Thu, Apr 12, 2012 at 10:52:48AM +0200, Christian Manal wrote:
> >> Hi,
> >>
> >> I recently updated to Samba 3.6.4 from 3.6.0 (on Solaris 10 x86). Since
> >> then, passwordless guest authentication makes smbd crash with a segfault.
> >>
> >> I run the following command to test if the Samba server is available via
> >> Nagios:
> >>
> >>    smbclient -U guest -N -L smb-serv
> >>
> >> Since the update, it returns with:
> >>
> >>   session setup failed: NT_STATUS_PIPE_BROKEN

Does the attached patch help?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
>From 911cb5448c4ce197eadd7c83b512f867d4fbf14e Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Thu, 12 Apr 2012 12:15:50 +0200
Subject: [PATCH] s3: Fix a segfault with debug level 3 on Solaris

printf can not deal with NULL strings
---
 source3/smbd/password.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/source3/smbd/password.c b/source3/smbd/password.c
index ddc7ad1..f032a56 100644
--- a/source3/smbd/password.c
+++ b/source3/smbd/password.c
@@ -294,7 +294,8 @@ int register_existing_vuid(struct smbd_server_connection *sconn,
 
 	DEBUG(3, ("register_existing_vuid: User name: %s\t"
 		  "Real name: %s\n", vuser->session_info->unix_name,
-		  vuser->session_info->info3->base.full_name.string));
+		  vuser->session_info->info3->base.full_name.string ?
+		  vuser->session_info->info3->base.full_name.string : ""));
 
 	if (!vuser->session_info->security_token) {
 		DEBUG(1, ("register_existing_vuid: session_info does not "
-- 
1.7.5.4