[Samba] (samba ~ shlight): negprot protocols not 0-terminated

[Volker Lendecke]

Hi!

On Sat, Nov 28, 2009 at 10:34:04PM +0100, Nagy Zoltan wrote:
> i've attached the requested info.
> 
> i've looked into the dump - and if i'm corret my samba server
> requires at least lanman2.1 capable client.

Thanks. This is a bug in sharity, together with an incorrect
paranoia check in Samba 3.2 and 3.3.

sharity gets the calculation of the netbios packet length
wrong, both the negprot and the tcon packets have 4 bytes of
random garbage at the end. This needs fixing.

The incorrect paranoia check in smbd has been fixed
implicitly with Samba 3.4, the attached patch to 3.2 should
make you get over this step. If you need that in the next
Samba 3.2 version (and hope the best it's picked up by
Debian), please open a bug with Debian and Samba.

I've also attached a (completely untested) patch to Sharity
light. Maybe you want to give that also a test and try to
get that through the Sharity people and/or the OpenBSD
package process.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba/attachments/20091129/6eaea6a6/attachment.pgp>