[Samba] Re: Bad patch for 3.2.7 - 3.2.8?

[Karolin Seeger]

On Tue, Mar 10, 2009 at 01:22:33AM +0000, ljb wrote:
> drescherjm at gmail.com wrote:
> > On Sun, Mar 8, 2009 at 9:50 PM, ljb <ljb1813 at pobox.com> wrote:
> >> Tried to upgrade from Samba-3.2.7 to 3.2.8 using the released patch:
> >>  http://download.samba.org/samba/ftp/patches/patch-3.2.7-3.2.8.diffs.gz
> >> But the patch would not apply. After getting the full 3.2.8 source
> >> release, it looks to me like this patch is not based on 3.2.7 but
> >> perhaps something newer, except some other files are missing from whatever
> >> it is based on.
> >>
> >>
> >> patching file docs/htmldocs/manpages/eventlogadm.8.html
> >> patching file docs/htmldocs/manpages/mount.cifs.8.html
> >> Hunk #2 FAILED at 23.
> >>...
> >
> > If that is the only error I would not worry at all about that. I mean
> > the mount.cifs.8.html file will not make a difference in the operation
> > of samba.
> 
> Not the only errors, just the first few.  I let it run further and
> got more, including this:
> 
> patching file source/configure
> Hunk #1 succeeded at 41383 (offset -2861 lines).
> Hunk #2 succeeded at 44254 with fuzz 2.
> Hunk #3 FAILED at 44451.
> Hunk #4 FAILED at 44513.
> Hunk #5 FAILED at 44550.
> Hunk #6 succeeded at 41946 with fuzz 1 (offset -2864 lines).
> Hunk #7 succeeded at 44888 with fuzz 1 (offset -1 lines).
> Hunk #8 succeeded at 42103 with fuzz 1 (offset -2865 lines).
> 3 out of 8 hunks FAILED -- saving rejects to file source/configure.rej
> 
> So if "configure" won't patch properly, I'm either doing something wrong or
> the patch doesn't start with 3.2.7.
> 
> Here's another weird thing. From the patch:
>   diff -u -r --new-file --exclude .svn --exclude CVS samba-3.2.7/WHATSNEW.txt
>     samba-3.2.8/WHATSNEW.txt
>   --- samba-3.2.7/WHATSNEW.txt    2009-01-28 11:35:11.000000000 +0100
>   +++ samba-3.2.8/WHATSNEW.txt    2009-02-03 17:10:07.000000000 +0100
> 
> Samba-3.2.7 was announced on 2009-01-05, so what is WHATSNEW.txt
> from 3.2.7 doing with a 2009-01-28 date?

It seems as something went wrong while creating the patch. I just uploaded
a new patch. Maybe it takes a while untile replication has taken place...
Please re-try with the new patch.

Thanks and sorry for the inconveniences!

Karolin

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba/attachments/20090310/feb15690/attachment.bin