[Samba] [PATCH] typo & type

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

ZIGLIO, Frediano, VF-IT wrote:
> Very silly patch. I like the english joke :)
> 
> type:
> 
> Index: nsswitch/nss_info_template.c
> ===================================================================
> --- nsswitch/nss_info_template.c        (revision 21498)
> +++ nsswitch/nss_info_template.c        (working copy)
> @@ -42,7 +42,7 @@
>                                        char **homedir,
>                                        char **shell,
>                                        char **gecos,
> -                                      uint32 *gid )
> +                                      gid_t *gid )
>  {
>         if ( !homedir || !shell || !gecos )
>                 return NT_STATUS_INVALID_PARAMETER;

Frediano,  The only problem is that the gid is parsed as
a uint32 through the winbindd code (in the request structure).
Did you experience a problem due to this?  Or just
stating that the gid_t type is more approriate (which I agree
with but that isa larger change)

The main problem in using gid_t is that we need a data type
of known size on both 32bit and 64bit compiles so that for
example /lib32/libnss_winbind.so can talk to a 64bit winbindd
running on the saying system.



> Index: nsswitch/nss_info.c
> ===================================================================
> --- nsswitch/nss_info.c (revision 21498)
> +++ nsswitch/nss_info.c (working copy)
> @@ -136,7 +136,7 @@
>         struct nss_function_entry *nss_backend;
>         struct nss_domain_entry *nss_domain;
> 
> -       /* The "template" backend should alqays be registered as it
> +       /* The "template" backend should always be registered as it
>            is a static module */

Thanks.  Fixing this now.





cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF3dJ+IR7qMdg1EfYRAnkXAJ4+As5xbcmhODHPClneMZunwEw4UQCePINn
cWG225hNUjjpTNgsL7SQ3TA=
=ng+F
-----END PGP SIGNATURE-----