[Samba] Re: psexec for Linux and svcctl.idl changes
jra at samba.org
Thu Jul 6 17:41:36 GMT 2006
On Thu, Jul 06, 2006 at 07:30:06PM +0200, Jelmer Vernooij wrote:
> He did send the diff to the IDL file, which I've just applied.
Yes I saw that.
> However, I'm not too keen on putting in the winexe patch (at least not
> in the current state.. I think linking a Windows binary into Samba is a
> very very bad idea.
> Also, there are also other minor issues:
> * Code style
> * Use of // for comments
> * Use of manually written prototypes in the C files
> * Use of direct headers (<termios.h>, etc) instead of <system/xx.h>
> * CamelCasing
> * The Windows code should (imho) go in some different place
> * Even /if/ we did think including a .exe in Samba was ok, 'winexe'
> should be made optional because we don't want to require people to
> install MSVC in order to build Samba.
These are minor things we can easily fix. I just don't want
this to get lost as it looks to provide significant functionality
More information about the samba