[Samba] BAD SIG[nature] errors from XP client

[Jeremy Allison]

On Sat, Aug 05, 2006 at 04:01:44PM -0400, Dale Sedivec wrote:
> On Sat, Aug 05, 2006 at 11:54:53AM -0700, Jeremy Allison wrote:
> > Signing should work. Can you log a bug at bugzilla.samba.org and
> > attach a full debug level 10 log from the smbd serving your client.
> 
> 	Done, #4003 <https://bugzilla.samba.org/show_bug.cgi?id=4003>.

Just fixed it - patch attached. This will be fixed in 3.0.23b.

Thanks a *lot* !

Jeremy.
-------------- next part --------------
Index: libsmb/smb_signing.c
===================================================================
--- libsmb/smb_signing.c	(revision 17428)
+++ libsmb/smb_signing.c	(working copy)
@@ -847,6 +847,9 @@
 
 	while (get_sequence_for_reply(&data->outstanding_packet_list, mid, &dummy_seq))
 		;
+
+	/* cancel doesn't send a reply so doesn't burn a sequence number. */
+	data->send_seq_num -= 1;
 }
 
 /***********************************************************