[Samba] new printing patch for 3.0.10 may fix the 'failure to remove print jobs from queue list display'

[David Landgren]

On Wed, 26 Jan 2005 16:25:35 +0100, Alex de Vaal <a.vaal at nh-hotels.com> wrote:
> On Wed 5 Jan 2005, at 17:57, Gerald (Jerry) Carter wrote:
> 
> > I've uploaded a new draft of the printing patch for 3.0.10
> > to http://www.samba.org/~jerry/patches/post-3.0.10/
> > The only change is a small fix to fix the register_message_flags()
> > error messages in the logs.  After some thought, I think this
> > might address the 'jobs failing to be removed from the queue
> > list' bug.  If people could test and let me know, I would
> > appreciate it.


I'm using 3.0.11pre1 (compiled on the 18th) and looking at the source
it looks like the patch is in (printing.c is dated Jan 4 21:30).
Printing with cups.

I am experiencing similar behaviour. I have 40 or so users pounding on
a number printers, and by the end of the day some of them show upwards
of 800 jobs in queue.

I am seeing things like "attempt to delete job 3575 not seen by lpr"
in the logs.

smb.conf contains
[global]
    load printers = yes
    printing = cups
    printcap = cups
    printcap cache time = 60
    printer admin = @prtadmin

[printers]
    comment = All Printers
    browseable = no
    path = /var/spool/samba
    printable = yes
    public = yes
    guest ok = yes
    writable = no
    create mode = 0700
    printer admin = root, @prtadmin

If anyone can throw me some clues I'd be very grateful.

Thanks,
David

> Hi Jerry,
> 
> The patch (version #2) is working; when I print from an XP client to a CUPS
> queue
> (queue on hold), the print icon appears in the taskbar of the XP client.
> When I remove
> the print job from the CUPS queue, within 30 seconds the print icon on the
> XP client
> disappears.
> 
> I also added this patch from Jerome Borsboom to your patch.
> 
> --- samba-3.0.10/source/printing/printing.c     2005-01-10
> 15:07:27.060999122 +0100
> +++ samba-3.0.10.new/source/printing/printing.c 2005-01-10
> 15:07:36.784464292 +0100
> @@ -1077,6 +1077,7 @@
> 
>        if ( !print_cache_expired(sharename, False) ) {
>                DEBUG(5,("print_queue_update_internal: print cache for %s is
> still ok\n", sharename));
> +               release_print_db( pdb );
>                return;
>        }
> 
> Is your printing patch Ok to use in production environments?
> 
> I saw that in the SAMBA_3_0 branch that printing/printing.c is changed with
> your patch, but your patch also patches:
> 
> param/loadparm.c
> smbd/lanman.c
> smbd/negprot.c
> smbd/reply.c
> smbd/server.c
> 
> but I can see that these files are not updated with your patch in the
> SAMBA_3_0
> branch, or am I wrong?
> 
> Regards,
> Alex.
> 
> --
> To unsubscribe from this list go to the following URL and read the
> instructions:  https://lists.samba.org/mailman/listinfo/samba
>