RETRACT: Re: [Samba] [PATCH] printing patch update

[Ryan Novosielski]

Isn't this supposed to be fixed in 3.0.11pre1 anyway?

---- _  _ _  _ ___  _  _  _
|Y#| |  | |\/| |  \ |\ |  |  | Ryan Novosielski - User Support Spec. III
|$&| |__| |  | |__/ | \| _|  | novosirj at umdnj.edu - 973/972.0922 (2-0922)
\__/ Univ. of Med. and Dent. | IST/ACS - NJMS Medical Science Bldg - C630

On Mon, 10 Jan 2005, Misty Stanley-Jones wrote:

> This mail was sent in error.  The patch does compile.
>
> On Monday 10 January 2005 09:33, Misty Stanley-Jones wrote:
>> On Monday 10 January 2005 09:15, Jerome Borsboom wrote:
>>> In reviewing the recent printing-3-0-10_v2 patch, I think I have
>>> found an omitted 'release_print_db'. The following patch
>>> corrects this.
>>>
>>> Regards,
>>>
>>> Jerome Borsboom
>>>
>>> --- samba-3.0.10/source/printing/printing.c	2005-01-10 15:07:27.060999122
>>> +0100 +++ samba-3.0.10.new/source/printing/printing.c	2005-01-10
>>> 15:07:36.784464292 +0100 @@ -1077,6 +1077,7 @@
>>>
>>>  	if ( !print_cache_expired(sharename, False) ) {
>>>  		DEBUG(5,("print_queue_update_internal: print cache for %s is still
>>> ok\n", sharename)); +		release_print_db( pdb );
>>>  		return;
>>>  	}
>>
>> I tried adding this to printing.c in 3.0.11pre1 and it does not compile:
>> Compiling printing/printing.c
>> printing/printing.c: In function `print_cache_expired':
>> printing/printing.c:1038: warning: passing arg 3 of `tdb_fetch_uint32' from
>> incompatible pointer type
>> printing/printing.c: In function `print_queue_update_internal':
>> printing/printing.c:2713: error: parse error at end of input
>> printing/printing.c:30: warning: `remove_from_jobs_changed' used but never
>> defined
>> make: *** [printing/printing.o] Error 1
>>
>> Just thought you would like to know,
>> Misty
> -- 
> To unsubscribe from this list go to the following URL and read the
> instructions:  https://lists.samba.org/mailman/listinfo/samba
>