[Samba] 3.0.7: PANIC: deferred_open_entries_identical: logic error

[Matt Phillips]

Jeremy-

On Sat, Sep 18, 2004 at 06:12:55PM -0700, Jeremy Allison wrote:
> On Sat, Sep 18, 2004 at 09:23:41AM -0400, Matt Phillips wrote:
> > After upgrading to 3.0.7 we've had 4 panics, all within seconds of each other.
> Arggg. Stupid, stupid, stupid me ! I added a paranoia test
> case when I was developing the deferred open case and made it
> too tight. It will fire (incorrectly) and panic when a client
> does a second open for a file with a different mid (multiplex-id)
> request. Doh ! This is a perfectly valid thing for a client to
> do (have two pending opens with different mids outstanding on
> the same file) and currently when the first pending open expires
> with a share violation the paranoia code will panic smbd.
> 
> It's a rare condition, but obvious now I'lve looked at the
> code.
> 
> Here is the patch. Sorry for that bug.

Thanks for looking at this and the patch.  I'm glad you found the bug...  I
was having a hard time reproducing it here.

-Matt


-- 
Matt Phillips <matt.phillips at ict.om.org>
International Coordinating Team, Operation Mobilisation
Public PGP Key: http://moses.om.org/~mattp/gpg.asc