[Samba] Samba 3.0.8 breaks all printing from Windows 98

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jonathan Knight wrote:
|
| We have small panic here as we've just put samba 3.0.8
| up to fix the DoS  attack but all printing from Windows 98
| has now broken.  Printing from  Windows XP is still working fine.

Reproduced it.  Try this patch.





cheers, jerry

- ---------------------------------------------------------------------
Alleviating the pain of Windows(tm)      ------- http://www.samba.org
GnuPG Key                ----- http://www.plainjoe.org/gpg_public.asc
"If we're adding to the noise, turn off this song"--Switchfoot (2003)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBk6PcIR7qMdg1EfYRAs1dAJ9pdRpLQHrS6I+Ag1ANUtCn0JHyEQCfQuQI
CYX/Sdt0bhT9lx7SbKKkefQ=
=kZ8M
-----END PGP SIGNATURE-----
-------------- next part --------------
Index: smbd/lanman.c
===================================================================
--- smbd/lanman.c	(revision 3681)
+++ smbd/lanman.c	(working copy)
@@ -2267,6 +2267,12 @@
 		return False;
 	*rparam_len = 4;
 	*rparam = REALLOC(*rparam,*rparam_len);
+
+	if ( (snum = lp_servicenumber(sharename)) == -1 ) {
+		DEBUG(0,("api_PrintJobInfo: unable to get service number from sharename [%s]\n",
+			sharename));
+		return False;
+	}
   
 	*rdata_len = 0;