[WORKAROUND] Re: [Samba] duplicate domains in browse list
Joerg.Pulz at frm2.tum.de
Sat May 29 11:44:45 GMT 2004
-----BEGIN PGP SIGNED MESSAGE-----
On Fri, 28 May 2004, Jeremy Allison wrote:
> On Fri, May 28, 2004 at 09:24:31AM +0200, Joerg Pulz wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > On Thu, 27 May 2004, Jeremy Allison wrote:
> > >Can you send me your smb.conf please. I'd really like to make
> > >sure I've fixed this for 3.0.5.
> > i send you 2 smb.conf files with this mail.
> > one file belongs to the PDC of our MAIN domain called 'ZWE-FRM-II', which
> > is also the WINS server for all other hosts. this server works on subnet
> > 172.25.1.0/24. the attached 'smb.conf_1' belongs to this server.
> > the second file belongs to a second PDC for domain 'PANDA', which works on
> > subnet 172.25.15.0/24 and uses the PDC of the 'ZWE-FRM-II' domain as WINS
> > server. the attached 'smb.conf_2' belongs to this server.
> Ok, this is the fix for this problem - this fix didn't make
> This perfectly explains the problem you're seeing - for workgroup
> names we were parsing 16 bytes (including the netbios type byte)
> instead of 15 bytes (only the name). This causes the trim_char
> call that should remove the extra space to fail :-(.
> --- lib/charcnv.c 2004-05-28 16:10:52.000000000 -0700
> +++ /home/jeremy/src/samba3.0/source/lib/charcnv.c 2004-05-27 15:04:24.000000000 -0700
> @@ -932,7 +932,7 @@
> size_t pull_ascii_nstring(char *dest, size_t dest_len, const void *src)
> - return pull_ascii(dest, src, dest_len, sizeof(nstring), STR_TERMINATE);
> + return pull_ascii(dest, src, dest_len, sizeof(nstring)-1, STR_TERMINATE);
your patch solves this problem PERFECTLY.
thank again for your help.
keep up the good work.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
-----END PGP SIGNATURE-----
More information about the samba