[WORKAROUND] Re: [Samba] duplicate domains in browse list

[Jeremy Allison]

On Thu, May 27, 2004 at 08:45:22PM +0200, Joerg Pulz wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Thu, 27 May 2004, Jeremy Allison wrote:
> 
> >Ok, all the changes here are just to reduce the size of string
> >used from an unstring to an nstring. Unfortunately this cannot
> >be correct as it would cause truncation for multibyte characters
> >in code pages like Japanese.
> >
> >It may be that the change you added causes extra non-zero bytes not
> >to be examined in the comparison functions. If that is the case
> >the following patch should have the same effect. If you could test
> >this instead of your patch I'd appreciate it.
> 
> I've tested the small patch on one DMB but it did NOT work.
> 
> I stopped 'smbd' and 'nmbd', removed the browse.dat file, installed the 
> new binaries, and started the whole thing.
> as soon as the browse.dat file is recreated, it contains domain names with 
> trailing spaces until MAX_NETBIOSNAME_LEN is reached.
> 
> I had to stop the processes to not pollute all browse lists again.

Thanks for testing it. Ok, the part I didn't know is that the
bad names in the browse list have trailing spaces. That helps
a lot in tracking this down. I'll mail more when I've investigated
it.

Thanks,

	Jeremy.