[Samba] Windows XP SP2 (Official) and Samba 3

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gerald (Jerry) Carter wrote:
| Gerald (Jerry) Carter wrote:
| | Bert Rapp wrote:
| | | I've looked through the archives and the only information
| | | I can find regarding Windows XP SP2 is RC2.  Has anyone
| | | out there had ANY experience with XP SP2 Official and a Samba
| | | 3 domain?
| |
| | Looks like MS did not fix the print change notify bug.
| |
| | I would not recommend installing it if you Samba is is serving
| | printers or unless you are running 3.0.6rc2.  3.0.6 final will
| | be out later this week.
|
| Looks like we will also release 2.2.11 to address this.
| (just remember that 2.2. is EOL on October 1, 2004).


Here's a patch.  Please test.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBGqB+IR7qMdg1EfYRAm52AJ41/Dq4SpBfH8i9RK0MrWRKxDENAQCeLDdw
g5UutSpgD9NhV+683ow0Qv0=
=ux2J
-----END PGP SIGNATURE-----
-------------- next part --------------
Index: source/rpc_server/srv_spoolss_nt.c
===================================================================
--- source/rpc_server/srv_spoolss_nt.c	(revision 1741)
+++ source/rpc_server/srv_spoolss_nt.c	(working copy)
@@ -2830,6 +2830,12 @@
 	info->data=NULL;
 	info->count=0;
 
+	/* a bug in xp sp2 rc2 causes it to send a fnpcn request without 
+	   sending a ffpcn() request first */
+
+	if ( !option )
+		return WERR_BADFID;
+
 	for (i=0; i<option->count; i++) {
 		option_type=&(option->ctr.type[i]);
 		
@@ -2891,6 +2897,12 @@
 	info->data=NULL;
 	info->count=0;
 
+	/* a bug in xp sp2 rc2 causes it to send a fnpcn request without 
+	   sending a ffpcn() request first */
+
+	if ( !option )
+		return WERR_BADFID;
+
 	get_printer_snum(p, hnd, &snum);
 
 	for (i=0; i<option->count; i++) {