[Samba] wins hook functionality broken in Samba 3.0.0

Tim Potter tpot at samba.org
Mon Sep 29 05:07:30 GMT 2003


I've just fixed a bug (#528 in bugzilla) to do with wins hook functionality.
The wins hook parameter is broken in Samba 3.0.0 but will be fixed in 3.0.1.

The attached patch against the release samba-3.0.0.tar.gz file can be used 
to fix it.


Tim.
-------------- next part --------------
Index: nmbd_winsserver.c
===================================================================
RCS file: /data/cvs/samba/source/nmbd/nmbd_winsserver.c,v
retrieving revision 1.51.2.12
retrieving revision 1.51.2.14
diff -c -u -r1.51.2.12 -r1.51.2.14
cvs server: conflicting specifications of output style
--- source/nmbd/nmbd_winsserver.c	27 Aug 2003 15:07:46 -0000	1.51.2.12
+++ nmbd_winsserver.c	29 Sep 2003 04:57:20 -0000	1.51.2.14
@@ -107,7 +107,7 @@
 {
 	pstring command;
 	char *cmd = lp_wins_hook();
-	char *p;
+	char *p, *namestr;
 	int i;
 
 	if (!cmd || !*cmd) return;
@@ -119,11 +119,17 @@
 		}
 	}
 	
+	/* Use the name without the nametype (and scope) appended */
+
+	namestr = nmb_namestr(&namerec->name);
+	if ((p = strchr(namestr, '<')))
+		*p = 0;
+
 	p = command;
 	p += slprintf(p, sizeof(command)-1, "%s %s %s %02x %d", 
 		      cmd,
 		      operation, 
-		      nmb_namestr(&namerec->name),
+		      namestr,
 		      namerec->name.name_type,
 		      ttl);
 


More information about the samba mailing list