[Samba] Bug in installclientlib

William R. Knox wknox at mitre.org
Tue Nov 25 17:16:08 GMT 2003


Needless to say, this patch should be against Makefile.in. Here is the
proper patch.

			Bill Knox
			Lead Operating Systems Programmer/Analyst
			The MITRE Corporation

On Tue, 25 Nov 2003, William R. Knox wrote:

> Date: Tue, 25 Nov 2003 12:07:15 -0500 (EST)
> From: William R. Knox <wknox at mitre.org>
> To: samba at samba.org
> Subject: [Samba] Bug in installclientlib
>
> There is a bug in the installclientlib section of the Makefile. If you
> redefine your LIBDIR during the configure step via a --libdir argument,
> the lib directory never gets created by the installdirs section, and the
> installation of the libsmbclient.* files gets done to a
> $(DESTDIR)${prefix}/lib file, not to the directory. The easy fix is to put
> @$(SHELL) $(srcdir)/script/installdirs.sh $(DESTDIR)${prefix}/lib
> at the beginning of the installclientlib section. Attached is the patch.
>
> 			Bill Knox
> 			Lead Operating Systems Programmer/Analyst
> 			The MITRE Corporation
>
-------------- next part --------------
--- samba-3.0.1pre3/source/Makefile.in	Thu Nov 13 22:40:36 2003
+++ samba-3.0.1pre3/source/Makefile.in.new	Tue Nov 25 12:12:08 2003
@@ -1237,6 +1237,7 @@
 	@$(SHELL) $(srcdir)/script/installswat.sh $(DESTDIR)$(SWATDIR) $(srcdir)
 
 installclientlib: installdirs libsmbclient
+	@$(SHELL) $(srcdir)/script/installdirs.sh $(DESTDIR)${prefix}/lib
 	-$(INSTALLCLIENTCMD_SH) bin/libsmbclient. at SHLIBEXT@ $(DESTDIR)${prefix}/lib
 	-$(INSTALLCLIENTCMD_A) bin/libsmbclient.a $(DESTDIR)${prefix}/lib
 	@$(SHELL) $(srcdir)/script/installdirs.sh $(DESTDIR)${prefix}/include


More information about the samba mailing list