[Samba] Threaten warnings while compiling Samba 2.2.7a on Solaris 2.5.1

[Andrew Bartlett]

On Tue, 2003-03-11 at 20:01, Pierre Lebrun wrote:
> I get warning messages while compiling samba 2.2.7a on Solaris with
> Sun cc 4.2
> - assignment type mismatch
> - argument #1 is incompatible with prototype
> - initializer does not fit or is out of range: -1
> 
> Must I change variables type in source code to fit what is guessed by 
> the compiler ?
> Is source 2.2.7a not compatible with Solaris 2.5.1 ?

Any portable C program will cause warnings on some compilers.  We aim to
reduce the number of warnings, as they can indicate bugs, but just the
compiler's warning alone does not mean there must be a bug on that
line.  Some parts of the Samba code do not cast between signed and
unsigned characters - and for our purposes they are identical.  This
kind of thing will cause a warning.  Likewise our use of 'const' may
cause warnings when compiling against broken LDAP headers.

Because these warnings *can* indicate bugs, we compile samba after every
checkin on over 30 different compiler/arch combinations at
build.samba.org, and developers are encouraged to study the compiler
output presented there.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba/attachments/20030313/0c2c594b/attachment.bin