[Samba] WinBind does not work well with Rational ClearCase ( bug fix attached :)

[Jazdzewski, StephenX A]

Gerald,

Comment quote:
"This should really be made into a 'winbind force group' smb.conf parameter
or something like that."


Originally in winbindd_user.c:
 00375 #if 0
 00376         /* Look in cache for entries, else get them direct */
 00377                     
 00378         if (winbindd_fetch_user_cache(ent->domain->name,
 00379                                       (struct getpwent_user **)
 00380                                       &ent->sam_entries, 
 00381                                       &ent->num_sam_entries)) {
 00382                 return True;
 00383         }
 00384 #endif
 00385 
 00386         /* For the moment we set the primary group for every user to
be the
 00387            Domain Users group.  There are serious problems with
determining
 00388            the actual primary group for large domains.  This should
really
 00389            be made into a 'winbind force group' smb.conf parameter or
 00390            something like that. */ 
 00391 
 00392         group_rid = DOMAIN_GROUP_RID_USERS;
 00393 
 00394         if (!domain_handles_open(ent->domain)) {
 00395                 return WINBINDD_ERROR;
 00396         }

Now (2.2.4) in winbindd_rpc.c:
                for (j=0;j<count;i++, j++) {
                        (*info)[i].acct_name = unistr2_tdup(mem_ctx,
&info1.str[
j].uni_acct_name);
                        (*info)[i].full_name = unistr2_tdup(mem_ctx,
&info1.str[
j].uni_full_name);
                        (*info)[i].user_rid = info1.sam[j].rid_user;
                        /* For the moment we set the primary group for
                           every user to be the Domain Users group.
                           There are serious problems with determining
                           the actual primary group for large domains.
                           This should really be made into a 'winbind
                           force group' smb.conf parameter or
                           something like that. */
                        (*info)[i].group_rid = DOMAIN_GROUP_RID_USERS;
                }

                talloc_destroy(ctx2);
        } while (NT_STATUS_EQUAL(result, STATUS_MORE_ENTRIES));

Thanks again,

-Stephen Jazdzewski, Steve at Jazd.com


-----Original Message-----
From: Gerald Carter [mailto:jerry at samba.org]
Sent: Thursday, May 16, 2002 12:39 PM
To: Jazdzewski, StephenX A
Cc: 'samba at samba.org'; 'Steve at Jazd.com'
Subject: RE: [Samba] WinBind does not work well with Rational ClearCase
( bug fix attached :)


On Thu, 16 May 2002, Jazdzewski, StephenX A wrote:

> Gerald,
> 
> No worries.
> 
> This patch is required if your using Rational ClearCase and you don't
> want everyone to have access to it.  It's to fix a brokenness (IMO)
> within ClearCase, and maybe other programs.  Our windows primary group
> has 10k+ users...

Yeah.  Makes sense why you would want this functionality.
In the NIS days you could do something like

+::<gid op rational group>::::

at the end of /etc/passwd and the NIS compatibility stuff
would take care of it for you.  Would be very helpful here.
 
> I will shoot it off to Rational, so they can provide it to there
> customers. I was hoping it could be applied to the main tree so I could
> just tell them to get the latest version of Samba, and it would then
> have the added benefit of being vetted by the experts.
> 
> There is a long standing comment within the source that something like
> this would be nice to have as an option.

our source ?  Where (file & line #)?

> Thank you for your time and consideration :)

Thanks for the patch :-)  Most people just point out the bug.  Few
people take the time to submit the correction :-)





cheers, jerry
 ---------------------------------------------------------------------
 Hewlett-Packard                                     http://www.hp.com
 SAMBA Team                                       http://www.samba.org
 --                                            http://www.plainjoe.org
 "Sam's Teach Yourself Samba in 24 Hours" 2ed.      ISBN 0-672-32269-2
 --"I never saved anything for the swim back." Ethan Hawk in Gattaca--