[Samba] Samba 2.2.5 Recycle Bin file permissions

[Dan O'Connor]

Thanks Giulio,

The patch:

    +   mode=S_IREAD|S_IWRITE|S_IEXEC|0010|0040;

turned on group read and execute bits, and I added '0020' to turn on the
write bit (so others' deleted files can be written to recycle
directories already owned by another user in the group):

    +   mode=S_IREAD|S_IWRITE|S_IEXEC|0010|0020|0040;

and it worked like a charm!

Thanks,

--Dan

P.S.  Any chance this file permissions 'feature' could be made a
configurable option in recycle.conf, instead of hard-coded in recycle.c?



----- Original Message -----
From: "Giulio Orsero" <giulioo at pobox.com>
To: "Samba List" <samba at lists.samba.org>
Sent: Thursday, June 27, 2002 11:05 PM
Subject: Re: [Samba] Samba 2.2.5 Recycle Bin file permissions


> On Thu, 27 Jun 2002 14:51:56 -0700, "Dan O'Connor"
<dan at ferrarishields.com>
> wrote:
>
> >The new VFS recycle bin, however, sets the file permissions on
deleted
> >files/directories to 700. This means that only the user who
> >modifies/deletes a file can access it in the recycle bin. Also, the
>
> You have to edit recycle.c:
>
> @@ -322,7 +323,7 @@
>     pstring newdir;
>
>     *newdir='\0';
> -   mode=S_IREAD|S_IWRITE|S_IEXEC;
> +   mode=S_IREAD|S_IWRITE|S_IEXEC|0010|0040;
>     pstrcpy(tempstr,dname);
>     y=tempstr;
>     /* Create directory tree if neccessary */
>
> This will grant read access to group.
>
> --
> giulioo at pobox.com