[Samba] Fix for smbpasswd Samba 2.2.4 on Solaris only taking 8 character passwords

[Andrew Gray]

REPLACE_GETPASS is not defined.  Here seem to be the bits from config.log:

configure:14786: checking whether getpass should be replaced
configure:14813:
gcc -c -O   -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I./ -I./include -I./
ubiqx -I./smbwrapper conftest.c >&5
In file included from lib/getsmbpass.c:21,
                 from configure:14800:
include/includes.h:689:18: popt.h: No such file or directory
configure:14816: $? = 1
configure: failed program was:
#line 14795 "configure"
#include "confdefs.h"

#define REPLACE_GETPASS 1
#define NO_CONFIG_H 1
#define main dont_declare_main
#include "./lib/getsmbpass.c"
#undef main

int
main ()
{

  ;
  return 0;
}
configure:14834: result: no

---
Andrew Gray
Systems Administrator
University of Nevada, Las Vegas
College of Engineering


----- Original Message -----
From: "Gerald Carter" <jerry at samba.org>
To: "Andrew Gray" <grayaw at egr.unlv.edu>
Cc: <samba at lists.samba.org>
Sent: Monday, June 17, 2002 1:21 PM
Subject: Re: [Samba] Fix for smbpasswd Samba 2.2.4 on Solaris only taking 8
character passwords


> On Mon, 17 Jun 2002, Andrew Gray wrote:
>
> > Under Samba 2.2.4 (and possibly earlier), smbpasswd (when run locally)
only
> > really reads the first 8 characters, as opposed to the full password.
> > Obviously, this can cause mass confusion. :)
> >
> > The fix is pretty simple (I would offer a diff, but this is the kind of
> > thing the configure script should check for...) - under Solaris
getpass()
> > will only return 8 characters - you must use getpassphrase() to get up
to
> > 256 characters (same syntax as getpass).
> >
> > So, under source/utils/smbpasswd.c, line 670, change
> >
> >     p = getpass(prompt);
> >
> > to
> >
> >     p = getpassphrase(prompt);
> >
> > And it works properly.
>
> This is actually a wrong fix.  We attempt to override
> with our own internal getpass() function.  This works fine
> on every Solaris box I have to test on.  Can you check and see
> if REPLACE_GETPASS is defined in include/config.h ?
> I need to know why the test is failing on certain Solaris boxes.
> Any help woulf be appreciated.
>
>
>
>
>
>
> cheers, jerry
>  ---------------------------------------------------------------------
>  Hewlett-Packard                                     http://www.hp.com
>  SAMBA Team                                       http://www.samba.org
>  --                                            http://www.plainjoe.org
>  "Sam's Teach Yourself Samba in 24 Hours" 2ed.      ISBN 0-672-32269-2
>  --"I never saved anything for the swim back." Ethan Hawk in Gattaca--
>
>