[Samba] Samba 2.2.x PDC code small corrections

rolnas at takas.lt rolnas at takas.lt
Sat Aug 10 05:12:07 GMT 2002

There some small changes in Samba 2.2.x PDC code for fake groups "Domain
Admins/Users/Guests" to work.

There also found bug in source/rpc_server/srv_samr_nt.c
@@ -227,7 +227,7 @@

	static_map[0].gid = (gid_t)-1;
	sid_copy(&static_map[0].sid, &global_sam_sid);
-	sid_append_rid(&static_map[1].sid, DOMAIN_GROUP_RID_ADMINS);
+	sid_append_rid(&static_map[0].sid, DOMAIN_GROUP_RID_ADMINS);
	static_map[0].sid_name_use = SID_NAME_DOM_GRP;
	fstrcpy(static_map[0].nt_name, "Domain Admins");
	fstrcpy(static_map[0].comment, "Administrators for the domain");

So before "Domains Admins" had bad domain sid.

Full patches are there http://www.mif.vu.lt/~rolnas/samba/.
I use them half year without problems.

Rolandas Naujikas

P.S. The code in source/passdb/passdb.c was before SAMBA_2_2_2(?) but gone.

More information about the samba mailing list