[Samba] Re: [PATCH] pam_winbind bug

[Hannes Schmidt]

This issue is currently beeing worked on, but it's not as simple a bug as it might seem. The socket is left open intentionally, for performance reasons. Although it's generally O.K. to do that, because all open file-handles get closed at program exit automatically, it might confuse some ill-written applications (cron, in my case) in rare situations. I would be curious as to what problems are you having, exactly. For more info, search the samba and samba-technical mailing list archives for my postings. Escpecially the thread "Winbind patch fixes broken client".

----- Original Message ----- 
From: "Timo Benk" <tik at talicom.de>
To: <samba at samba.org>
Cc: "Timo Benk" <tik at talicom.de>
Sent: Wednesday, August 07, 2002 10:52 AM
Subject: [Samba] Re: [PATCH] pam_winbind bug


> Since the socket in winbind_nss.c is not closed
> too there maybe a similar problem.
> 
> However i am not deep enough into the code to
> say if the socket should be closed in wb_common.c,
> but since the socket needs to be closed somewhere,
> and since the time when socket is no more needed
> is not fixed, i think that the socket should be closed
> in pam_winbind.c, resp. winbind_nss.c.
> 
> Only my 2 cents:-)
> 
> -timo
> 
> On Wed, Aug 07, 2002 at 10:35:57AM +0200, Timo Benk wrote:
> > Hi,
> > 
> > The socket which is opened in write_sock() from
> > wb_common.c is never closed in pam_winbind.c.
> > 
> > The attached patch fixes the problem for me in the 
> > pam winbind module.
> > 
> > -timo
> -- 
> To unsubscribe from this list go to the following URL and read the
> instructions:  http://lists.samba.org/mailman/listinfo/samba
>