Improvements/bugfixes for smbmount in 2.2.0-alpha1

Urban Widmark urban at teststation.com
Sun Jan 14 19:22:17 GMT 2001


Hello

Here is an updated patch with things I'd like included in smbmount 2.2.0.
In no particular order ...

2.4.0 support:
+ Allows smbmount to pass options in ascii format to smbfs.
  This is useful for adding new parameters to smbfs and still have old
  smbmounts work. Also makes smbfs more like other linux filesystems.
  Specifically for nls support and future intr/timeout options.

Improved logging:
+ Always enable debug. "bad interaction with autofs" fixed by letting
  smbmount write to a logfile after becoming a daemon.
+ Convert "fprintf(stderr" to "DEBUG(0" to log error messages
+ Add process id to logmessages to separate error messages from different
  smbmounts. Could be done with multiple logfiles instead.

lib/debug.c:
+ allow a second call to change status from interactive to non-interactive

Minor annoyances:
+ Fix memory and socket leak on smbfs reconnects
+ If smbmount gets a reconnect signal it should not continue unless it
  actually manages to open a new connection (else SIGSEGV).
+ Allow smbmount to unmount if there is a problem with the ioctl (missing
  close)

Improvements from smbclient:
+ free(c) on error, guess on identical netbois and dns machine name
+ PASSWD_FD/PASSWD_FILE support and "-A" support as credentials=<path>
  (Why have both? why different formats?
   How does PASSWD_FD work? where does it get the fd from? ...)

Documentation:
+ yodldocs for smbmount, smbmnt and smbumount, translated from the
  manpages and updated. (no manpages included)


Patch at:
http://samba.org/samba-patches?findid=215

or if you prefer:
http://www.hojdpunkten.ac.se/054/samba/smbmount-2.2.0-alpha1-ascii+fixes.patch

[ This patch includes everything from the earlier patch vs 2.0.7
  http://samba.org/cgi-bin/samba-patches/incoming?id=179;user=guest ]

And even if you are not Jeremy you are still allowed to download and test
this (please do). The improved logging part might be helpful for those who
are experiencing smbmount reconnection problems.

/Urban





More information about the samba mailing list