Warning messages compiling --with-pam - pampass.c and pass_check.c

[dennis]

I'm using Samba 220, Solaris 2.8/Sparc, Sun Forte C Compiler.
I ran ./configure using --with-pam so I could use winbind.

During compilation, I get the following warning messages:
............
Compiling passdb/secrets.c
Compiling passdb/pass_check.c
"passdb/pass_check.c", line 671: warning: statement not reached
Compiling passdb/ldap.c
Compiling passdb/nispass.c
Compiling passdb/smbpasschange.c
Compiling passdb/tdbpass.c
Compiling passdb/pampass.c
"passdb/pampass.c", line 129: warning: initialization type mismatch
Compiling printing/pcap.c
............

In pass_check.c, I think there's a misspelling at line 668:

   667  /* #ifndef HAVE_CRYPT */
   668  #ifndef HAVE_CRYPT        <--- "ifdef" is misspelled - Dennis
   669      DEBUG(1, ("Warning - no crypt available\n"));
   670      return (False); 
   671  #else /* HAVE_CRYPT */
   672      return (strcmp((char *)crypt(password, this_salt),
this_crypted) == 0);
   673  #endif /* HAVE_CRYPT */

I changed "ifndef" to "ifdef" and the message went away.

In pampass.c, I can't really tell, since I'm not sure what this code
section
is supposed to do, define a struct? init a struct? both?:

   127  
   128  static struct pam_conv PAM_conversation = {
   129      &PAM_conv,
   130      NULL
   131  };
   132 

Can anyone check this and let me know?
thanks

Dennis