Samba 2.2.0 "allow hosts" issue

[Gerald Carter]

On Thu, 19 Apr 2001, Andrew Dawson wrote:

> After some investigation, I believe that the problem lies with line
> 269 of source/lib/access.c. In the absence of a '/' character in the
> input string, this simply returns a pointer to the entire string. This
> is then incorrectly assumed to be an IP address and hostname-based
> authentication breaks.

Doh!  Looks like you right.  Thanks.  I'm fixing this in CVS now.

> Replacing the strtok() function call with a simple strchr() call,
> along with a change to the corresponding DEBUG line (see diff below)
> seems to have resolved the problem for us, although I can't guarantee
> this hasn't caused something else to break!





Cheers, jerry

----------------------------------------------------------------------
   /\  Gerald (Jerry) Carter                     Professional Services
 \/    http://www.valinux.com/  VA Linux Systems   gcarter at valinux.com
       http://www.samba.org/       SAMBA Team          jerry at samba.org
       http://www.plainjoe.org/                     jerry at plainjoe.org

       "...a hundred billion castaways looking for a home."
                                - Sting "Message in a Bottle" ( 1979 )