SAMBA: a typo in source/locking/shmem_sysv.c

Gerald Carter gcarter at valinux.com
Tue Oct 17 05:06:43 GMT 2000


Thanks Dennis,

All the locking code has been rewritten for 2.2 so this 
file does not exist anymore.  Nice catch for 2.0.7 
though. :-)



Cheers, jerry

Dennis Vshivkov wrote:
> 
>         Hello.
> 
>         Searching through the source while exploring 
> Samba locking subsystem, I noticed a possible typo: while 
> opening a semaphore in sysv_shm_open(), one of return 
> code checks tests a wrong id variable, instead of 
> sem_id it checks shm_id, which has not been messed with 
> yet.  Here is the patch:




----------------------------------------------------------------------
   /\  Gerald (Jerry) Carter                     Professional Services
 \/    http://www.valinux.com/  VA Linux Systems   gcarter at valinux.com
       http://www.samba.org/       SAMBA Team          jerry at samba.org
       http://www.plainjoe.org/                     jerry at plainjoe.org

       "...a hundred billion castaways looking for a home."
                                - Sting "Message in a Bottle" ( 1979 )






More information about the samba mailing list