No subject

[David Lee]

Re:

> Date:   Wed, 01 Mar 2000 11:09:50 -0800
> From:   Jeremy Allison <jeremy at valinux.com>
> To:     giulioo at pobox.com
> Subject: Re: SAMBA_2_0 (recent CVS): smbpasswd and utmp errors
> Message-ID: <38BD6AFE.229EDE05 at valinux.com>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
> 
> Orsero wrote:
> > 
> > [...]
> > 2) ./configure --with-utmp:
> > make all
> > ..
> > Compiling smbd/connection.c
> > smbd/connection.c: In function `utmp_update':
> > smbd/connection.c:349: structure has no member named `ut_syslen'
> > make: *** [smbd/connection.o] Error 1
> 
> Thanks Giulio , I'm on it.
> 
> Jeremy.

Since then, I have had reports of other two or three other operating
systems also lacking "ut_syslen".  Perhaps the way to address this (and
perhaps this is what you are doing anyway, Jeremy!) is to put an: 
    AC_DEFUN(AC_UT_SYSLEN, ...
(or similar) into aclocal.m4 so that "configure" can test this and pick it
up.  (And, of course, rebuild the "configure" script before shipping.)

While on this subject, the very next line in connection.c is:
   pstrcpy(ux.ut_host, host);
which is probably prone to overflow (though my knowledge of the "ptstr..." 
parts of Samba is zero).  Might "safe_strcpy(...)" be better?  I have seen
"utmpx.h" files where ut_host declarations vary from 257 down to 64. 

Hope that helps.

-- 

:  David Lee                                I.T. Service          :
:  Systems Programmer                       Computer Centre       :
:                                           University of Durham  :
:  http://www.dur.ac.uk/~dcl0tdl            South Road            :
:                                           Durham                :
:  Phone: +44 191 374 2882                  U.K.                  :