[2.0.6] doesn't run under Solaris 7/sparc, Internal Error

[Jeremy Allison]

David Collier-Brown wrote:

> This snippet make it look like smbd put out an error message
> mentioning "attempt_netb"... and segv'd.
> 
> What are the last half-dozen message in the log? One of them
> should be "attempt_netbios_session_request: %s rejected the session.
> Error was : %s.\n"
> 
> This appears once, at line 3257 in libsmb/clientgen.c:
>   File           Line
> 1 clientgen.c    3224 BOOL attempt_netbios_session_request(struct
> cli_state
>                       *cli, char *srchost, char *desthost,
>                         struct in_addr *pdest_ip)
> which is called from:
> 3 cli_netlogon.c  532 if (!attempt_netbios_session_request(&cli,
>                         global_myname, remote_machine, &cli.dest_ip)) {
> 4 password.c      998 if (!attempt_netbios_session_request(cli,
>                          global_myname, desthost, &dest_ip))
> 5 password.c     1158 if (!attempt_netbios_session_request(pcli,
>                         global_myname, remote_machine, &dest_ip)) {
> 
> -----
> Ok, that's where it died, smack in the middle of a compound if,
> and the error message in the log should tell us how to reproduce
> the failure and the bug, plus may help us avoid it...

Ok - I know this one. I've fixed it for 2.0.7. Here's
the patch to 2.0.6.

Cheers,

	Jeremy.

Index: libsmb/clientgen.c
===================================================================
RCS file: /data/cvs/samba/source/libsmb/clientgen.c,v
retrieving revision 1.88.2.12.2.10
diff -u -r1.88.2.12.2.10 clientgen.c
--- clientgen.c 1999/11/08 17:23:46     1.88.2.12.2.10
+++ clientgen.c 1999/11/12 02:13:15
@@ -3253,9 +3253,9 @@
     if (!nmb_name_equal(&called, &smbservername) ||
         !cli_initialise(cli) ||
         !cli_connect(cli, desthost, pdest_ip) ||
-        !cli_session_request(cli, &calling, &called)) {
-          DEBUG(0,("attempt_netbios_session_request: %s rejected the session. \
-Error was : %s.\n", desthost, cli_errstr(cli)));
+        !cli_session_request(cli, &calling, &smbservername)) {
+          DEBUG(0,("attempt_netbios_session_request: %s rejected the session for name *SMBSERVER.",
+                desthost));
           cli_shutdown(cli);
           return False;
     }


-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------