2.0.7pre3: smbclient issues

[Jeremy Allison]

Giulio Orsero wrote:
> 
> 1c) dir listing compatibility with win9x/nt
> When connecting with smbclient to a win share, the . and .. dir are
> showed in the top share too, even if .. obviously cannot be cd'ed into.
> I know . and .. in the topshare are useless, but if win does this way...
> If samba did like win9x/nt do, then the error at point ii) would go away
> automatically.

I've found & fixed the code in Samba that was explicitly
not doing this on the root of a share. It looks like it
was an agressive optimisation when returning directory
lists.

smbclient now works correctly with this.

Here's the patch against 2.0.7pre3.

Jeremy.

---------------------cut here--------------------------------------
Index: smbd/trans2.c
===================================================================
RCS file: /data/cvs/samba/source/smbd/trans2.c,v
retrieving revision 1.105.2.22.2.10
diff -u -r1.105.2.22.2.10 trans2.c
--- trans2.c	2000/03/28 02:38:30	1.105.2.22.2.10
+++ trans2.c	2000/04/04 01:08:49
@@ -320,9 +320,6 @@
   uint32 len;
   time_t mdate=0, adate=0, cdate=0;
   char *nameptr;
-  BOOL isrootdir = (strequal(conn->dirpath,"./") ||
-		    strequal(conn->dirpath,".") ||
-		    strequal(conn->dirpath,"/"));
   BOOL was_8_3;
   int nt_extmode; /* Used for NT connections instead of mode */
   BOOL needslash = ( conn->dirpath[strlen(conn->dirpath) -1] != '/');
@@ -395,9 +392,6 @@
       if (dont_descend && !isdots)
         continue;
 	  
-      if (isrootdir && isdots)
-        continue;
-
       pstrcpy(pathreal,conn->dirpath);
       if(needslash)
         pstrcat(pathreal,"/");
---------------------cut here--------------------------------------

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------