access problems for restricted clients

[jpetermann at dow.com]

We use our SAMBA-Server in server security mode (conf entry: security =
server).

After upgrade to version 1.9.17p2 users which has to login to the
Windows network only from explicit defined Win95-stations can't access
any ressource of the SAMBA share.

The reason was the code change in "password.c" based of the suggestion
of Frank Varnavas (see: "RE: NT server dropping APPS due to samba").

After reestblishing the old code everything works fine again.

...
  p = outbuf+len;

  /* and my name */
#ifdef _VARN_FIX
  /* Fix from Frank Varnavas <varnavas at ny.ubs.com>.
     We cannot use the same name as the client to 
     the NT password server, as NT will drop client
     connections if the same client name connects
     twice. Instead, synthesize a name from our pid.
     and the remote machine name.
   */
  {
    char buf[32]; /* create name as PIDname */
    sprintf(buf,"%d", getpid());
    strncpy(&buf[strlen(buf)], remote_machine, 31 - strlen(buf));
    buf[31] = '\0';
    DEBUG(1,("negprot w/password server as %s\n",buf));
    name_mangle(buf,p,' ');
    len += name_len(p);
  }
#else
  name_mangle(remote_machine,p,' ');
  len += name_len(p);
#endif
  _smb_setlen(outbuf,len);
...

My question:
Is this a clean solution?
When not what is to do ?


Joachim Petermann

DOW BSL, Werk Schkopau
Internet: jpetermann at dow.com
____________________________________________________
The opinions expressed above are those of the author 
and not of The Dow Chemical Company