[PATCH] smb: common: add header guards to fs/smb/common/smb2status.h

[Steve French]

Looks like your suggested change works.  My change had a typo which you spotted.

On Sun, Feb 8, 2026 at 2:39 PM Stefan Metzmacher <metze at samba.org> wrote:
>
> Am 07.02.26 um 04:41 schrieb Steve French:
> > updated the patch with your suggestion in cifs-2.6.git for-next (see
> > attached).  Let me know if any objections or if you spot any problems.
> >
> >
> > On Fri, Feb 6, 2026 at 3:42 AM Stefan Metzmacher <metze at samba.org> wrote:
> >>
> >> Am 05.02.26 um 22:31 schrieb David Howells:
> >>> Stefan Metzmacher <metze at samba.org> wrote:
> >>>
> >>>> diff --git a/fs/smb/client/Makefile b/fs/smb/client/Makefile
> >>>> index 802dec276e15..3abd357d6df6 100644
> >>>> --- a/fs/smb/client/Makefile
> >>>> +++ b/fs/smb/client/Makefile
> >>>> @@ -47,7 +47,7 @@ cifs-$(CONFIG_CIFS_COMPRESSION) += compress.o compress/lz77.o
> >>>>    #
> >>>>    # Build the SMB2 error mapping table from smb2status.h
> >>>>    #
> >>>> -$(obj)/smb2_mapping_table.c: $(srctree)/fs/smb/common/smb2status.h \
> >>>> +$(obj)/smb2_mapping_table.c: $(src)/../common/smb2status.h \
> >>>>                               $(src)/gen_smb2_mapping
> >>>>           $(call cmd,gen_smb2_mapping)
> >>>
> >>> That looks reasonable.  Do you have a patch for it, if so, you can add:
> >>>
> >>>        Reviewed-by: David Howells <dhowells at redhat.com>
> >>
> >> I'd propose that Steve just squashes this into your commit
> >> cifs: Autogenerate SMB2 error mapping table
>
> The attached patch has this
>
> +$(obj)/smb2_mapping_table.c: $(src)/fs/smb/common/smb2status.h \
> +                           $(src)/gen_smb2_mapping
> +       $(call cmd,gen_smb2_mapping)
>
> Which is even worse, it has to be
>
> $(src)/../common/smb2status.h
>
> metze



-- 
Thanks,

Steve